OCPBUGS-62153: E2E: Fix for checking L3 Cache spans entire numa node #1406
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mrniranjan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The earlier pr openshift#1397 used to compare if the cpus returned by ccx are same as numa node 0, which may not be same, even though the size matches. This cause the test to not skip on vm. Signed-off-by: Niranjan M.R <mniranja@redhat.com>
mrniranjan
force-pushed
the
fix_skip_llc_vm
branch
from
9a977a0 to
8b72d91
Compare
|
@ffromani can you review this |
|
@mrniranjan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
mrniranjan
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-62153, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| // ccx cpus may be 0-11, and numa node0 cpus could be 0,2,4,6,8,10,12,14,16,18,22 | ||
| // if we were to compare the equality, the equality fails and tests will not be | ||
| // skipped atleast on Virtual machines | ||
| if len(numaInfo[0]) == L3CacheGroupSize { |
There was a problem hiding this comment.
comparing the size is too coarse grained and makes for unnecessary skips. What creates this difference between CCX cpus and NUMA node cpus?
There was a problem hiding this comment.
we don't know why . On libvirt when we create vm's we specify the cpu id's of numa nodes in the vm definition , the cache hierarchy that libvirt tries to emulate probably doesn't take in to account the cpu id's. Either way if the total cpus sharing the cache and number of cpus in that node match, shouldn't that be enough to say that there is no specific subset of cpus sharing L3 cache ?
There was a problem hiding this comment.
This seems to work by coincidence; or, alternatively, I can't see a reliable way to skip which takes in account this odd case. Rather than guess, let's label VM nodes and skip based on labels. At least it's very explicit and consistent and easy to understand.
There was a problem hiding this comment.
@ffromani I am closing this PR, I have modified the cpu topology on VM's to use the same toplogy as it lists in shared_cpu_list
NUMA node(s): 2
NUMA node0 CPU(s): 0-11
NUMA node1 CPU(s): 12-23
sh-5.1# cat /sys/devices/system/cpu/cpu0/cache/index3/shared_cpu_list
0-11
sh-5.1# cat /sys/devices/system/cpu/cpu1/cache/index3/shared_cpu_list
0-11
sh-5.1# cat /sys/devices/system/cpu/cpu12/cache/index3/shared_cpu_list
12-23
sh-5.1# cat /sys/devices/system/cpu/cpu13/cache/index3/shared_cpu_list
12-23
so the current code should work.
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-62153. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
The earlier pr #1397 used to compare if the cpus
returned by ccx are same as numa node 0, which
may not be same, even though the size matches. This cause the test to not skip on vm.